Skip to content

Add test coverage for certificate credentials in SystemCredentialsTest#2823

Merged
timja merged 4 commits intojenkinsci:masterfrom
somiljain2006:Credentials-test-todo
Apr 10, 2026
Merged

Add test coverage for certificate credentials in SystemCredentialsTest#2823
timja merged 4 commits intojenkinsci:masterfrom
somiljain2006:Credentials-test-todo

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 10, 2026 •
edited
Loading

Add certificate credentials support and assertions in SystemCredentialsTest

  • Add support for testing uploaded certificate credentials via JCasC
  • Configure certificate using base64-encoded PKCS12 keystore
  • Verify:
    • credential creation and ID
    • password resolution from environment variables
    • keystore source type (UploadedKeyStoreSource)
    • keystore bytes integrity
  • Retain existing assertions for username/password and SSH credentials
  • Ensure secrets are not exposed in logs

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates a feature that works or fixes the issue.

@somiljain2006 somiljain2006 requested a review from a team as a code owner April 10, 2026 07:27
timja
timja reviewed Apr 10, 2026
View reviewed changes
Comment thread integrations/src/test/java/io/jenkins/plugins/casc/SystemCredentialsTest.java
timja
timja approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@timja timja added the test A PR that adds to testing - used by Release Drafter label Apr 10, 2026
@timja timja merged commit 2ee8907 into jenkinsci:master Apr 10, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the Credentials-test-todo branch April 10, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timja timja timja approved these changes

Assignees

No one assigned

Labels

test A PR that adds to testing - used by Release Drafter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@somiljain2006 @timja